replace position vectors with bitset iterators (-23.58%)#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eliminates the intermediate
Vec<u32>position arrays by iterating comma and newline bitsets directly during field extractionextract_positionstook 20% ofdecodetime. Previously,decodeextracted every set bit from the comma and newline bitsets intoVec<u32>position arrays, thenextract_from_cache()indexed into these arraysProfiling showed
Vec::pushinsideextract_positionsas a hot spot due to the per-element capacity checks + writes across positions.Now, this PR adds a bitset iterator stored directly in the decoder. When fields are extracted, bitsets are walked on the fly using trailing_zeros and bit clear, computing positions from the
u64itself